Skip to content

Remove unused macros #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
4 commits merged into from
Dec 11, 2019
Merged

Remove unused macros #610

4 commits merged into from
Dec 11, 2019

Conversation

yoshuawuyts
Copy link
Contributor

Removes our async-macros dependency entirely, and inlines all remaining code. Even managed to maintain our current docs when re-exporting task::ready! from futures-core. This patch should strictly speed up compilation. Thanks!

k-nasa
k-nasa approved these changes Dec 7, 2019
View reviewed changes
Copy link
Member

@k-nasa k-nasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@ghost ghost merged commit a0f3b3b into master Dec 11, 2019
@ghost ghost deleted the remove-unused-macros branch December 11, 2019 11:49
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-nasa k-nasa k-nasa approved these changes

+1 more reviewer
Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoshuawuyts @k-nasa